Remove redundant code

src/main/java/hudson/plugins/git/GitTool.java

@@ -95,11 +95,11 @@ public static GitTool getDefaultInstallation() {
     }
 
     public GitTool forNode(Node node, TaskListener log) throws IOException, InterruptedException {
-        return new GitTool(getName(), translateFor(node, log), Collections.<ToolProperty<?>>emptyList());
+        return new GitTool(getName(), translateFor(node, log), Collections.emptyList());
     }
 
     public GitTool forEnvironment(EnvVars environment) {
-        return new GitTool(getName(), environment.expand(getHome()), Collections.<ToolProperty<?>>emptyList());
+        return new GitTool(getName(), environment.expand(getHome()), Collections.emptyList());
     }
 
     @Override
@@ -126,7 +126,7 @@ public static void onLoaded() {
         }
 
         String defaultGitExe = isWindows() ? "git.exe" : "git";
-        GitTool tool = new GitTool(DEFAULT, defaultGitExe, Collections.<ToolProperty<?>>emptyList());
+        GitTool tool = new GitTool(DEFAULT, defaultGitExe, Collections.emptyList());
         descriptor.setInstallations(new GitTool[] { tool });
         descriptor.save();
     }

src/main/java/hudson/plugins/git/IGitAPI.java

@@ -131,7 +131,7 @@ public interface IGitAPI extends GitClient {
      * @throws hudson.plugins.git.GitException if underlying git operation fails.
      * @throws java.lang.InterruptedException if interrupted.
      */
-    public void fetch(String repository, String refspec) throws GitException, InterruptedException;
+    void fetch(String repository, String refspec) throws GitException, InterruptedException;
 
     /**
      * Retrieve commits from RemoteConfig.

src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

@@ -2680,7 +2680,7 @@ public CheckoutCommand deleteBranchIfExist(boolean deleteBranch) {
 
             @Override
             public CheckoutCommand sparseCheckoutPaths(List<String> sparseCheckoutPaths) {
-                this.sparseCheckoutPaths = sparseCheckoutPaths == null ? Collections.<String>emptyList() : sparseCheckoutPaths;
+                this.sparseCheckoutPaths = sparseCheckoutPaths == null ? Collections.emptyList() : sparseCheckoutPaths;
                 return this;
             }
 
@@ -3584,7 +3584,7 @@ Output shows SHA1 and tag with (optional) marker for annotated tags
          */
         String[] output = result.split("[\\n\\r]+");
         if (output.length == 0 || (output.length == 1 && output[0].isEmpty())) {
-            return Collections.<GitObject>emptySet();
+            return Collections.emptySet();
         }
         Pattern pattern = Pattern.compile("(\\p{XDigit}{40})\\s+refs/tags/([^^]+)(\\^\\{\\})?");
         Map<String, ObjectId> tagMap = new HashMap<>();

src/main/java/org/jenkinsci/plugins/gitclient/GitClient.java

@@ -147,7 +147,7 @@ public interface GitClient {
      * @throws hudson.plugins.git.GitException if underlying git operation fails.
      * @throws java.lang.InterruptedException if interrupted.
      */
-    public void init() throws GitException, InterruptedException;
+    void init() throws GitException, InterruptedException;
 
     /**
      * add.
@@ -897,7 +897,7 @@ public interface GitClient {
      * @throws hudson.plugins.git.GitException if underlying git operation fails.
      * @throws java.lang.InterruptedException if interrupted.
      */
-    public List<String> showRevision(ObjectId r) throws GitException, InterruptedException;
+    List<String> showRevision(ObjectId r) throws GitException, InterruptedException;
 
     /**
      * Given a Revision, show it as if it were an entry from git whatchanged, so that it

src/main/java/org/jenkinsci/plugins/gitclient/GitURIRequirementsBuilder.java

@@ -156,7 +156,7 @@ private GitURIRequirementsBuilder(@NonNull List<DomainRequirement> requirements)
      */
     @NonNull
     public static GitURIRequirementsBuilder create() {
-        return new GitURIRequirementsBuilder(Collections.<DomainRequirement>emptyList());
+        return new GitURIRequirementsBuilder(Collections.emptyList());
     }
 
     /**

src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java

@@ -278,7 +278,7 @@ public CheckoutCommand deleteBranchIfExist(boolean deleteBranch) {
 
             @Override
             public CheckoutCommand sparseCheckoutPaths(List<String> sparseCheckoutPaths) {
-                this.sparseCheckoutPaths = sparseCheckoutPaths == null ? Collections.<String>emptyList() : sparseCheckoutPaths;
+                this.sparseCheckoutPaths = sparseCheckoutPaths == null ? Collections.emptyList() : sparseCheckoutPaths;
                 return this;
             }
 
@@ -2442,7 +2442,7 @@ public String getAllLogEntries(String branch) throws InterruptedException {
      * Adds all the refs as start commits.
      */
     private void markAllRefs(RevWalk walk) throws IOException {
-        markRefs(walk, Predicates.<Ref>alwaysTrue());
+        markRefs(walk, Predicates.alwaysTrue());
     }
 
     /**

src/main/java/org/jenkinsci/plugins/gitclient/JGitApacheTool.java

@@ -21,7 +21,7 @@ public JGitApacheTool(final List<? extends ToolProperty<?>> properties) {
     }
 
     public JGitApacheTool() {
-        this(Collections.<ToolProperty<?>>emptyList());
+        this(Collections.emptyList());
     }
 
     /** {@inheritDoc} */

src/main/java/org/jenkinsci/plugins/gitclient/JGitTool.java

@@ -31,7 +31,7 @@ public JGitTool(List<? extends ToolProperty<?>> properties) {
      * Constructor for JGitTool.
      */
     public JGitTool() {
-        this(Collections.<ToolProperty<?>>emptyList());
+        this(Collections.emptyList());
     }
 
 

src/main/java/org/jenkinsci/plugins/gitclient/MergeCommand.java

@@ -34,7 +34,7 @@ public interface MergeCommand extends GitCommand {
      */
     MergeCommand setStrategy(Strategy strategy);
 
-    public enum Strategy {
+    enum Strategy {
         DEFAULT, RESOLVE, RECURSIVE, OCTOPUS, OURS, SUBTREE, RECURSIVE_THEIRS;
 
         @Override
@@ -53,7 +53,7 @@ public String toString() {
      */
     MergeCommand setGitPluginFastForwardMode(GitPluginFastForwardMode fastForwardMode);
 
-    public enum GitPluginFastForwardMode {
+    enum GitPluginFastForwardMode {
         FF,        // Default option, fast forward update the branch pointer only
         FF_ONLY,   // Create a merge commit even for a fast forward
         NO_FF;     // Abort unless the merge is a fast forward

src/main/java/org/jenkinsci/plugins/gitclient/UnsupportedCommand.java

@@ -22,7 +22,7 @@ public class UnsupportedCommand {
      * @return this for chaining
      */
     public UnsupportedCommand sparseCheckoutPaths(List<String> sparseCheckoutPaths) {
-        List<String> sparseList = sparseCheckoutPaths == null ? Collections.<String>emptyList() : sparseCheckoutPaths;
+        List<String> sparseList = sparseCheckoutPaths == null ? Collections.emptyList() : sparseCheckoutPaths;
         if (!sparseList.isEmpty()) {
             useJGit = false;
         }