[JENKINS-63146] Use credentials.file.encoding property for passphrase file #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
force-pushed
the
passphrase-charset-honor-env-var
branch
2 times, most recently
from
eb3b015 to
668cd8a
Compare
MarkEWaite
changed the title
MarkEWaite
changed the title
MarkEWaite
changed the title
…in passphrase file Intentionally uses a Java property for portability. Logs the passphrase charset change. Add credentials.file.encoding docs
MarkEWaite
force-pushed
the
passphrase-charset-honor-env-var
branch
from
668cd8a to
2fc643d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-63146 Honor credentials.file.encoding property for passphrase file
Not consistent with usage in other locations in the plugin that use the ibm.system.encoding Java property rather than an environment variable. Setting an environment variable may be a little easier.
Checklist
Types of changes
Further comments
If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.