[JENKINS-50394] Add ability for JenkinsRule tests to insert custom GitClient implementation #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As what is returned from Git.getClient
JENKINS-50394 - When new commits are pushed to the repository while GitSCMSource is discovering branches then MissingObjectException
To be able to verify a fix for JENKINS-50394 I needed some way of detecting various phases in the descovery process of AbstractGitSCMSource, an easy way would be if I can use a custom "mocked" version of GitClient during the test that injects some more refs in the middle of the fetch/discoverBranches sequence.
Checklist
Types of changes
Further comments
Added a guard so that this only activates during JenkinsRule tests so that normal production code won't be affected of able to be otherwise "persuaded".
Upstream to jenkinsci/git-plugin#702