Always run known hosts tests locally #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No issues have been detected in local execution of the known hosts tests. Don't reduce the detection opportunities in local development environments or in environments that are not one of the ci.jenkins.io servers.
Not valuable enough to deal with the disruption of unreliable tests. Tests are run regularly in my CI environment without issue and they are run by every developer that executes the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always run known hosts tests locally
No issues have been detected in local execution of the known hosts tests. Don't reduce the detection opportunities in local development environments or in environments that are not one of the ci.jenkins.io servers.
Testing done
Confirmed that tests are executed locally and not skipped. Rely on ci.jenkins.io test run to confirm that tests are skipped as expected when run there.
Submitter checklist