Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gson-api plugin instead of bundling gson-api jar #1077

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Use gson-api plugin instead of bundling gson-api jar #1077

merged 2 commits into from
Dec 9, 2023

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Dec 6, 2023 •
edited by MarkEWaite
Loading

Depend on gson-api plugin instead of bundling gson-api jar

Do not bundle the gson-api jar file as a transitive dependency when there is already a gson-api Jenkins plugin available.

Added to bom so that the version number can be retrieved from the plugin bill of materials in a future BOM release:

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

@jonesbusy jonesbusy force-pushed the feature/depends-on-gson-api branch from a152ac5 to 9a6d033 Compare December 6, 2023 16:00
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 6, 2023
@MarkEWaite MarkEWaite changed the title Depends on gson-api instead Use gson-api plugin instead of bundling gson-api jar Dec 6, 2023
@MarkEWaite
Copy link
Contributor

@jonesbusy this looks great to me. The plugin bill of materials will release with the gson-api plugin added this Saturday. Then this pull request can be updated to depend on that new version of the plugin bill of materials and the version property can be removed from the dependency reference.

@MarkEWaite MarkEWaite added dependencies Dependency related change and removed chore Reduces maintenance effort by changes not directly visible to users labels Dec 6, 2023
@jonesbusy
Copy link
Contributor Author

Perfect will leave the PR like this until the BOM release

@MarkEWaite
Copy link
Contributor

Perfect will leave the PR like this until the BOM release

In the interim, I'll submit a separate pull request to update the minimum Jenkins version to 2.401.3 because I want a separate changelog entry for that change.

MarkEWaite added a commit to MarkEWaite/git-client-plugin that referenced this pull request Dec 6, 2023
@MarkEWaite
Require Jenkins 2.401.3 or newer
2b8ce09 
The gson-api plugin has been added to the bom-2.401.x line. That will
allow the plugin to stop bundling the transitive dependency on the
gson-api jar file.  That reduces the size of the hpi file and avoids
duplicating the gson-api file in multiple locations inside Jenkins.

jenkinsci#1077 from
@jonesbusy inspired this pull request.
@MarkEWaite MarkEWaite mentioned this pull request Dec 6, 2023
Merged
9 tasks
@jonesbusy
Copy link
Contributor Author

In the interim, I'll submit a separate pull request to update the minimum Jenkins version to 2.401.3 because I want a separate changelog entry for that change.

Sure I will rebase when merged and remove the version when the bom is released

MarkEWaite added a commit that referenced this pull request Dec 7, 2023
@MarkEWaite
Require Jenkins 2.401.3 or newer (#1078)
e79346d 
The gson-api plugin has been added to the bom-2.401.x line. That will
allow the plugin to stop bundling the transitive dependency on the
gson-api jar file.  That reduces the size of the hpi file and avoids
duplicating the gson-api file in multiple locations inside Jenkins.

#1077 from
@jonesbusy inspired this pull request.
@jonesbusy jonesbusy force-pushed the feature/depends-on-gson-api branch from 9a6d033 to 79d75ec Compare December 8, 2023 08:07
@github-actions github-actions bot removed the dependencies Dependency related change label Dec 8, 2023
@jonesbusy jonesbusy force-pushed the feature/depends-on-gson-api branch from 79d75ec to a63004c Compare December 9, 2023 10:32
@jonesbusy jonesbusy marked this pull request as ready for review December 9, 2023 10:32
@jonesbusy jonesbusy requested a review from a team as a code owner December 9, 2023 10:32
@MarkEWaite MarkEWaite mentioned this pull request Dec 9, 2023
Merged
11 tasks
MarkEWaite
MarkEWaite approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite enabled auto-merge (squash) December 9, 2023 11:04
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 9, 2023
@MarkEWaite MarkEWaite merged commit b75cdbc into jenkinsci:master Dec 9, 2023
14 checks passed
@jonesbusy jonesbusy deleted the feature/depends-on-gson-api branch December 9, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesbusy @MarkEWaite