Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71661] jsoneditor.js overwrites standard CustomEvent JS function #98

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Jul 17, 2023

https://issues.jenkins.io/browse/JENKINS-71661

Condition of CustomEvent existence before defining it.

Testing done

Tested with some simple extended choice parameters,
with the condition, the CustomEvent isn't redefined (standard one is used), and the parameters are correctly displayed:
Monosnap Jenkins 2023-07-17 15-43-25

jsoneditor.min.js diff:
Monosnap History: jsoneditor min js 2023-07-17 16-00-35

Submitter checklist

Preview Give feedback

@jgreffe jgreffe requested a review from a team as a code owner July 17, 2023 13:34
@jgreffe jgreffe changed the title [JENKINS-71661] jsoneditor.js overwrites standard CustomEvent JS func… [JENKINS-71661] jsoneditor.js overwrites standard CustomEvent JS function Jul 17, 2023
@basil
Copy link
Member

basil commented Jul 18, 2023

Condition of CustomEvent existence before defining it

Based on https://caniuse.com/customevent I think it can be deleted entirely. Reference:

@chonton chonton merged commit 72e4bad into jenkinsci:main Jul 19, 2023
@batmat
Copy link
Member

batmat commented Jul 19, 2023

@chonton thanks! Could you please release a version?
I see Incrementals is enabled, but not a full-blown or a CD release. Thanks!

@batmat
Copy link
Member

batmat commented Jul 19, 2023

My bad, I had missed that this plugin had CD enabled.

@batmat
Copy link
Member

batmat commented Jul 19, 2023

Erm, actually, the CD release was skipped because this PR had no "interesting" label. And it failed when retriggered... 🤔

@chonton
Copy link
Collaborator

chonton commented Jul 19, 2023 via email

@batmat
Copy link
Member

batmat commented Jul 20, 2023

Awesome thanks! I do see the version 375.v72e4b_a_d33d33 from https://plugins.jenkins.io/extended-choice-parameter/ and from Jenkins, but I do not see the tag here.

Maybe you didn't push the new tag to the repo here yet? Thank you

image

@batmat
Copy link
Member

batmat commented Jul 20, 2023

Oh, I was notified of something else that is probably connected to the missing tag: the release notes are still in Draft on https://github.com/jenkinsci/extended-choice-parameter-plugin/releases
image

And indeed on plugins.jenkins.io, one can see that this release misses its release notes
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants