Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest opencsv version and replace with builder #62

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Use latest opencsv version and replace with builder #62

merged 2 commits into from
Dec 4, 2022

Conversation

StefanSpieker
Copy link
Contributor

Use latest opencsv version and replace with builder. Superseeds #49

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@StefanSpieker StefanSpieker requested a review from a team as a code owner November 27, 2022 12:30
@chonton
Copy link
Collaborator

chonton commented Nov 27, 2022

Thank you for your contribution!

Could you add some unit tests and/or improve the documentation as well?

@chonton chonton merged commit 2248f50 into jenkinsci:master Dec 4, 2022
@chonton
Copy link
Collaborator

chonton commented Dec 4, 2022

Thanks again!

@chonton chonton mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chonton chonton chonton left review comments

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanSpieker @chonton