Code cleanup #23
Merged
Code cleanup #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pom.xml
Outdated
| <packaging>hpi</packaging> | ||
| <version>0.77-SNAPSHOT</version> | ||
| <name>Extended Choice Parameter Plug-In</name> | ||
| <url>http://wiki.jenkins-ci.org/display/JENKINS/Extended+Choice+Parameter+plugin</url> |
There was a problem hiding this comment.
All the POMs I have seen don't (yet) use the jenkins.io URL.
Isn't this URL in the POM more for developers than for plugin users? The wiki, where the content can be edited, should be the correct place.
|
Hi @vimil, @olivergondza and @oleg-nenashev, as some time already passed since this pull-request was created, I just wanted to check if it can be merged? |
|
Let's try another ping. |
|
The plugin appears unmaintained. Some of the contributors might consider adopting it. |
vimil
approved these changes
Apr 3, 2019
Remove outdated comment too.
It is already defined in the parent pom.
|
I rebased on master to resolve the merge conflict in pom.xml. |
|
@vimil could you have a look at this? |
vimil
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.