[JENKINS-57125] Trim the value and request parameter options

[therealsujitk]

Relevant Issues

• https://issues.jenkins.io/browse/JENKINS-57125
• buildWithParameteres #99

The reason for this issue is because the plugin's function splits the valueStr by commas (,) and does not account for possible spaces between them.

String valueStr = "option1, option2, option3, option4";
String[] values = valueStr.split(); // ["option1", " option2", " option3", " option4"]

Notice the space prefix in the strings. Because of this when a parameter is passed using /buildWithParameters without the space prefix, it gets ignored.

[POST] /buildWithParameters?parameter=option1&parameter=option2

Here option1 gets accepted, however option2 gets ignored. To solve this I've split the valueStr by commas and taken spaces into consideration. Additionally I have also trimmed the values that are passed by the user.

Workaround

The temporary solution is to remove all the spaces from the options string in the job configuration, if that isn't possible you can pass the value to the endpoint along with the space (%20) as shown below.

[POST] /buildWithParameters?parameter=option1&parameter=%20option2

Testing done

1. Create a project with an Extend Choice Parameter of type Multi Select. Set the value as a string separated by commas and be sure to include spaces.
   
2. To test this I was initially getting a No valid crumb was included error while trying to make a POST request, so I disabled CSRF protection to get around this.
3. Trigger a build from the API endpoint with this key, I've done this using the curl command.

   curl http://localhost:5000/jenkins/job/Test%20Pipeline/buildWithParameters --data parameter=option1 --data parameter=option2

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue