Replace Verdana font for metrics calculation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
force-pushed
the
replace-verdana-font
branch
from
cbfd2b2 to
9a111b6
Compare
The Bitstream Vera font license allows redistribution and is claimed to be metrically compatible with Verdana. The unit test in this pull request indicates that the metric compatibility may not extend to the width of individual characters as measured in this use case. Even if the metrics are different, it is much better for users that we deliver a working plugin with open source components rather than suspending the distribution of the plugin due to the proprietary font.
MarkEWaite
force-pushed
the
replace-verdana-font
branch
from
9a111b6 to
00bb608
Compare
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Verdana font for metrics calculation
The Verdana font is a proprietary font that is not licensed for redistribution in source form. The Jenkins governance board has noted that is not compatible with Jenkins licensing standards. See the mailing list for more details.
Replaces the proprietary font with a redistributable font that is stated to be metrically compatible with Verdana.
Depends on #83 and #85
Still needs interactive testing to confirm that the replacement font behaves as expected.