Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer non-wildcard imports, even for tests #254

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

MarkEWaite
Copy link
Contributor

Prefer non-wildcard imports, even in tests

The wildcard imoprt is more difficult to read.

Thanks to OpenRewrite for the steps that started this change.

https://docs.openrewrite.org/recipes/java/testing/junit5/usehamcrestassertthat

Testing done

Confirmed tests pass with Java 21 on Linux.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

The wildcard imoprt is more difficult to read.

Thanks to OpenRewrite for the steps that started this change.

https://docs.openrewrite.org/recipes/java/testing/junit5/usehamcrestassertthat
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 21, 2023 16:15
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Oct 21, 2023
@MarkEWaite MarkEWaite merged commit 6994748 into jenkinsci:master Oct 21, 2023
15 checks passed
@MarkEWaite MarkEWaite deleted the prefer-non-wildcard-import branch October 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant