[JENKINS-70464] Test AddEmbeddableBadgeConfigStep

[abhishekmaity]

In response #114,

Testing done

• AddEmbeddableBadgeConfigStepTest.java
• currently, test coverage is as shown below

After changes, test coverage stands as shown below

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[abhishekmaity]

@MarkEWaite added a test case to improve code coverage.

[MarkEWaite]

@MarkEWaite added a test case to improve code coverage.

Very good. That's a nice step.

There are some things that can improve in your development process. The plugin uses automated source code formatting so that source code formatting differences do not distract maintainers when reviewing proposed code changes. Your pull request has not been formatted with the automated source code formatter. That indicates you did not run the command mvn verify to run the tests and confirm the static analysis checks pass (like spotbugs and source code formatting).

Before submitting a pull request, it is a good practice to run mvn verify, since that is what will be done by the CI job. The CI job failed because you need to update the formatting of the source code. . When you run mvn verify, you'll see a failure message that advises you to run mvn spotless:apply

Run the command mvn spotless:apply to format the source code, then push the resulting commit to the repository.

A little more info about source formatting is in the contributing guide.

[abhishekmaity]

@MarkEWaite added a test case to improve code coverage.

Very good. That's a nice step.

There are some things that can improve in your development process. The plugin uses automated source code formatting so that source code formatting differences do not distract maintainers when reviewing proposed code changes. Your pull request has not been formatted with the automated source code formatter. That indicates you did not run the command mvn verify to run the tests and confirm the static analysis checks pass (like spotbugs and source code formatting).

Before submitting a pull request, it is a good practice to run mvn verify, since that is what will be done by the CI job. The CI job failed because you need to update the formatting of the source code. . When you run mvn verify, you'll see a failure message that advises you to run mvn spotless:apply

Run the command mvn spotless:apply to format the source code, then push the resulting commit to the repository.

A little more info about source formatting is in the contributing guide.

@MarkEWaite Thanks for pointing out this important aspect. mvn verify and mvn spotless:apply now applied to PR

[MarkEWaite]

Thanks! This is a great start. Would love to have additional pull requests that further improve the test coverage.

[abhishekmaity]

Thanks! This is a great start. Would love to have additional pull requests that further improve the test coverage.

@MarkEWaite Yes, I will try to my best knowledge.