Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring and character set cleanup #242

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

StefanSpieker
Copy link
Contributor

Minor refactoring:

  • use switch instead of if-else
  • use StandardCharsets instead of strings
  • use diamond operator
  • and removed obsolete semicolons and imports

Testing done

Ran all unit tests and played with it in a debug environment

Submitter checklist

Preview Give feedback

@StefanSpieker StefanSpieker requested a review from a team as a code owner October 1, 2023 16:45
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Improvement looks good to me

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Oct 1, 2023
@MarkEWaite MarkEWaite changed the title Minor refactoring Minor refactoring and character set cleanup Oct 1, 2023
@MarkEWaite MarkEWaite merged commit d111338 into jenkinsci:master Oct 1, 2023
@StefanSpieker StefanSpieker deleted the minor_refactoring branch October 1, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants