Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow range of width values in tests #110

Merged
merged 4 commits into from
Aug 20, 2022

Conversation

MarkEWaite
Copy link
Contributor

Allow a range of width values in status image tests

Windows computers in my CI cluster report slightly different values for text widths than the Windows computers on ci.jenkins.io.

Linux and other computers report same values.

Specific values are not as important as keeping the width value within a reasonable range.

  • Allow range of width values in tests

Other changes included in the pull request include:

  • Remove unused imports from test code
  • Move PNG content type test code together
  • Remove variable portion of image path from test

None of those other improvements are substantial enough to justify a separate pull request.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Windows computers in my CI cluster report different width values
than the Windows computers on ci.jenkins.io .  The precise width values
have not been an issue, so long as they are within reasonable limits.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Aug 20, 2022
@MarkEWaite MarkEWaite merged commit 8b7507f into jenkinsci:master Aug 20, 2022
@MarkEWaite MarkEWaite deleted the range-of-width-values branch August 20, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant