Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test config change handling (#164) #177

Merged
merged 18 commits into from
Nov 15, 2024
Merged

Improve test config change handling (#164) #177

merged 18 commits into from
Nov 15, 2024

Conversation

MarioFuchsTT
Copy link
Collaborator

Resolves #164

@MarioFuchsTT MarioFuchsTT self-assigned this Sep 12, 2024
@MarioFuchsTT MarioFuchsTT added the documentation Improvements or additions to documentation label Sep 12, 2024
@MarioFuchsTT MarioFuchsTT force-pushed the i164_improve-test-config-change-handling branch from f59a966 to 92b5f33 Compare October 4, 2024 10:32
MartinGroscheTT
MartinGroscheTT requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@MartinGroscheTT MartinGroscheTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use multiple @QueryParameter within TestConfig.groovy to show the user the relationship between both parameters and KEEP 
    FormValidation doCheckTbcPath(@QueryParameter("tbcPath") String tbcPatch,
                                    @QueryParameter("tcfPath") String tcfPath) {
    // check implememntation to WARN the user if one of the parameter is KEEP and the other is not
}
  • using the snippet generator it is not possible to set tbc or tcf empty, find a way to make it possible so the user can unload the configuration via snippet generator (Hint: use Optional Block)

src/test/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/RunPackageStepIT.groovy Outdated Show resolved Hide resolved
src/test/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/RunPackageStepIT.groovy Outdated Show resolved Hide resolved
@MarioFuchsTT MarioFuchsTT force-pushed the i164_improve-test-config-change-handling branch from 7ea33e4 to d315fb2 Compare October 21, 2024 08:12
MartinGroscheTT
MartinGroscheTT requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@MartinGroscheTT MartinGroscheTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • currently the snippet generator allows both ttRunPackage testCasePath: 'test.pkg', testConfig: [forceConfigurationReload: true, tbcPath: 'test.tbc', tcfPath: 'test.tcf']
  • this should be tested

...in/resources/de/tracetronic/jenkins/plugins/ecutestexecution/configs/TestConfig/config.jelly Outdated Show resolved Hide resolved
...in/resources/de/tracetronic/jenkins/plugins/ecutestexecution/configs/TestConfig/config.jelly Outdated Show resolved Hide resolved
...in/resources/de/tracetronic/jenkins/plugins/ecutestexecution/configs/TestConfig/config.jelly Outdated Show resolved Hide resolved
...sources/de/tracetronic/jenkins/plugins/ecutestexecution/configs/TestConfig/config.properties Outdated Show resolved Hide resolved
@MartinGroscheTT MartinGroscheTT self-requested a review November 5, 2024 09:11
MartinGroscheTT
MartinGroscheTT requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@MartinGroscheTT MartinGroscheTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups

@MartinGroscheTT MartinGroscheTT force-pushed the i164_improve-test-config-change-handling branch from 875e834 to 2912487 Compare November 15, 2024 09:11
MarioFuchsTT and others added 17 commits November 15, 2024 12:15
@MarioFuchsTT @MartinGroscheTT
Extend/Update documentation (#164)
2ed7b85
@MarioFuchsTT @MartinGroscheTT
Extend tests (#164)
d192cf9
@MarioFuchsTT @MartinGroscheTT
Format tests and provide ref link in README (#164)
d37e06c
@MarioFuchsTT @MartinGroscheTT
Remove outdated advanced doc (#164)
48a6529
@MarioFuchsTT @MartinGroscheTT
Sync README with main (#164)
14e6efb
@MarioFuchsTT @MartinGroscheTT
Update README with main (#164)
5450304
@MarioFuchsTT @MartinGroscheTT
Move testconfig related information from README to advancedUsage (#164)
9620818
@MarioFuchsTT @MartinGroscheTT
Add review notes (#164)
0ec2e3f 
- remove keep
- ajust jelly, avdanvedDocs, and tests
@MarioFuchsTT @MartinGroscheTT
Add review notes (#164)
c07ef72 
- ensure either load configuration or keep configuration in snippet generator
- adjust jelly and properties file
- sync tests
@MarioFuchsTT @MartinGroscheTT
Add review note (#164)
8dae168 
- enhance configOption handler in TestConfig
- sync tests
@MarioFuchsTT @MartinGroscheTT
Add review notes (#164)
2e39235 
- provide console log for configOption and sync related tests
- provide test for behavior of keeping tbc/tcf paths empty
@MarioFuchsTT @MartinGroscheTT
Provide keepConfig and loadConfig behavior for TestConfig and sync te…
5406da2 
…sts (#164)
@MartinGroscheTT
Update loadConfig process (#164)
2005175 
- adapt Docs
- add help information in jelly
- provide TestConfig tests
@MartinGroscheTT
Update for changed loadConfig handling (#164)
e8bb586
@MartinGroscheTT
Fix escaping (#164)
0094672
@MartinGroscheTT
Delete unnecessary test (#164)
04cd208
@MartinGroscheTT
Rename test (#164)
ea3d5b9
@MartinGroscheTT MartinGroscheTT force-pushed the i164_improve-test-config-change-handling branch from 56dc5b0 to 12c7672 Compare November 15, 2024 11:15
@MartinGroscheTT MartinGroscheTT self-assigned this Nov 15, 2024
@MarioFuchsTT MarioFuchsTT merged commit 1940e07 into main Nov 15, 2024
18 checks passed
@MarioFuchsTT MarioFuchsTT deleted the i164_improve-test-config-change-handling branch November 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinGroscheTT MartinGroscheTT MartinGroscheTT approved these changes

Assignees

@MartinGroscheTT MartinGroscheTT

@MarioFuchsTT MarioFuchsTT

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test config change handling
2 participants
@MarioFuchsTT @MartinGroscheTT