Improve Error Handling for tt-steps (#138) #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinGroscheTT
requested changes
Jun 4, 2024
There was a problem hiding this comment.
- do we need to adapt this line as well
- getExeFileOnNode still throws an IllegalArgumentException -> please check all classes for adaption needed
- no tests found for those code changes
src/main/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/RunPackageStep.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/RunTestFolderStep.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/RunTestFolderStep.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/StartToolStep.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/de/tracetronic/jenkins/plugins/ecutestexecution/steps/StartToolStep.groovy
Outdated
Show resolved
Hide resolved
- revert throw declarations - convert e messages to AbortExceptions - enhance hint messages - extend tests
For those, exceptions are now caught and converted to an AbortException, along with their messages.
This will now be handled within the catch block of its calling method. |
MartinGroscheTT
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #138