Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Spotbugs Findings #64

Closed
8 tasks done
TT-S3-D1 opened this issue Aug 21, 2023 · 0 comments · Fixed by #68
Closed
8 tasks done

Fix Spotbugs Findings #64

TT-S3-D1 opened this issue Aug 21, 2023 · 0 comments · Fixed by #68
Assignees
@ErikRehmTT
Labels
chore Maintenance changes and refactoring

Comments

@TT-S3-D1
Copy link
Contributor

TT-S3-D1 commented Aug 21, 2023 •
edited by MartinGroscheTT
Loading

Describe the feature request

As a plugin maintainer I want to have a clean code base.

Upstream changes

  • only fixes for code
  • ignore violations for tests
  • ignore violations for generated code

Acceptance criteria

  • fix EI_EXPOSE_REP
  • fix EI_EXPOSE_REP2
  • fix MS_EXPOSE_REP
  • fix SE_NO_SERIALVERSIONID
  • fix ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
@TT-S3-D1 TT-S3-D1 added the chore Maintenance changes and refactoring label Aug 21, 2023
@ErikRehmTT ErikRehmTT self-assigned this Aug 31, 2023
ErikRehmTT added a commit that referenced this issue Sep 1, 2023
@ErikRehmTT
Resolve SE_NO_SERIALVERSIONID issues (#64)
1e831fc
ErikRehmTT added a commit that referenced this issue Sep 1, 2023
@ErikRehmTT
Fix all EI_EXPOSE_REP findings (#64)
479b6b2
ErikRehmTT added a commit that referenced this issue Sep 4, 2023
@ErikRehmTT
Ignore EI2 for closures (#64)
04756e6
ErikRehmTT added a commit that referenced this issue Sep 4, 2023
@ErikRehmTT
Add when condition for system tests (#64)
dd80a40
ErikRehmTT added a commit that referenced this issue Sep 4, 2023
@ErikRehmTT
Fix MS_EXPOSE_REP issues (#64)
05871b1
ErikRehmTT added a commit that referenced this issue Sep 5, 2023
@ErikRehmTT
Fix remaining spotbugs findings (#64)
b07bbd2
@ErikRehmTT ErikRehmTT mentioned this issue Sep 5, 2023
Merged
ErikRehmTT added a commit that referenced this issue Sep 7, 2023
@ErikRehmTT
Apply review remarks (#64)
f92317a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikRehmTT ErikRehmTT

Labels
chore Maintenance changes and refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spotbug findings jenkinsci/ecu-test-execution-plugin
2 participants
@TT-S3-D1 @ErikRehmTT