Make trend charts theme-aware #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `JenkinsPalette` that can be used to obtain colors that are supported by the current Jenkins theme. All line charts can now handle fixed colors or CSS color variables that will be resolved on the client side using the actual values of the selected theme.
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=============================================
+ Coverage 34.61% 51.42% +16.81%
- Complexity 9 17 +8
=============================================
Files 6 7 +1
Lines 78 105 +27
Branches 3 3
=============================================
+ Hits 27 54 +27
Misses 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
All pie charts can now handle fixed colors or CSS color variables that will be resolved on the client side using the actual values of the selected theme.
This was referenced May 15, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import static org.assertj.core.api.Assertions.*; | ||
|
|
||
| class JenkinsPaletteTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
JenkinsPalettethat can be used to obtain colors that are supported by the current Jenkins theme. All line charts can now handle fixed colors or CSS color variables that will be resolved on the client side using the actual values of the selected theme.Downstream PRs
Light Theme
Dark Theme