Use String#isEmpty where possible

jenkinsci · Dec 17, 2024 · c55c3d4 · c55c3d4
1 parent f2721f0
commit c55c3d4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/hudson/plugins/ec2/EC2SpotSlave.java b/src/main/java/hudson/plugins/ec2/EC2SpotSlave.java
@@ -200,7 +200,7 @@ public void terminate() {
                             }
 
                             // Terminate the agent if it is running
-                            if (instanceId != null && !instanceId.equals("")) {
+                            if (instanceId != null && !instanceId.isEmpty()) {
                                 if (!super.isAlive(true)) {
                                     /*
                                      * The node has been killed externally, so we've nothing to do here

diff --git a/src/main/java/hudson/plugins/ec2/SlaveTemplate.java b/src/main/java/hudson/plugins/ec2/SlaveTemplate.java
@@ -1455,7 +1455,7 @@ public Set<String> getSecurityGroupSet() {
     }
 
     public Set<String> parseSecurityGroups() {
-        if (securityGroups == null || "".equals(securityGroups.trim())) {
+        if (securityGroups == null || securityGroups.trim().isEmpty()) {
             return Collections.emptySet();
         } else {
             return new HashSet<>(Arrays.asList(securityGroups.split("\\s*,\\s*")));

diff --git a/src/main/java/hudson/plugins/ec2/Tenancy.java b/src/main/java/hudson/plugins/ec2/Tenancy.java
@@ -17,7 +17,7 @@ public String toString() {
     }
 
     public static Tenancy fromValue(String value) {
-        if (value != null && !"".equals(value)) {
+        if (value != null && !value.isEmpty()) {
             for (Tenancy enumEntry : values()) {
                 if (enumEntry.toString().equals(value)) {
                     return enumEntry;

diff --git a/src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java b/src/main/java/hudson/plugins/ec2/win/EC2WindowsLauncher.java
@@ -48,7 +48,7 @@ protected void launchScript(EC2Computer computer, TaskListener listener)
 
         try {
             String initScript = node.initScript;
-            String tmpDir = (node.tmpDir != null && !node.tmpDir.equals("")
+            String tmpDir = (node.tmpDir != null && !node.tmpDir.isEmpty()
                     ? WindowsUtil.quoteArgument(Util.ensureEndsWith(node.tmpDir, "\\"))
                     : "C:\\Windows\\Temp\\");