Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a packaging Git commitId/Tag reference to Docker images #865

Closed
oleg-nenashev opened this issue Jul 29, 2019 · 4 comments · Fixed by #1225
Closed

Add a packaging Git commitId/Tag reference to Docker images #865

oleg-nenashev opened this issue Jul 29, 2019 · 4 comments · Fixed by #1225
Labels
enhancement

Comments

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jul 29, 2019 •
edited
Loading

Currently there is no way to reliably track down which version of https://github.com/jenkinsci/docker was used to package the image. It would be great to inject a file to the Docker image which references the commit ID or, later, a tag.

Such information can be used by users to track down changes, especially for weekly releases when changelogs from #856 are not available
@vx-github vx-github mentioned this issue Oct 1, 2019
Closed
@glefloch
Copy link

glefloch commented Oct 9, 2019

@oleg-nenashev I would like to work on this. Couldn't we just add a label on the image ? if you prefer a file, where should we put it and how do we name it?

@oleg-nenashev
Copy link
Member Author

@glefloch label would be even better, you are right

@glefloch glefloch mentioned this issue Oct 9, 2019
Closed
@hjwk
Copy link

hjwk commented Oct 5, 2021

is this issue still valid ?

@timja
Copy link
Member

timja commented Oct 5, 2021

yes

shaneog added a commit to shaneog/docker that referenced this issue Oct 23, 2021
@shaneog
Add git commit SHA to Docker images
06a9f2f 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
@shaneog shaneog mentioned this issue Oct 23, 2021
Merged
6 tasks
shaneog added a commit to shaneog/docker that referenced this issue Oct 24, 2021
@shaneog
Add git commit SHA to Docker images
9f34e9e 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
shaneog added a commit to shaneog/docker that referenced this issue Oct 24, 2021
@shaneog
Add git commit SHA to Docker images
7c7ca49 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
shaneog added a commit to shaneog/docker that referenced this issue Oct 24, 2021
@shaneog
Add git commit SHA to Docker images
2898530 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
shaneog added a commit to shaneog/docker that referenced this issue Oct 24, 2021
@shaneog
Add git commit SHA to Docker images
2a7f5c2 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
shaneog added a commit to shaneog/docker that referenced this issue Oct 24, 2021
@shaneog
Add git commit SHA to Docker images
e2d535e 
Add the full git commit SHA to the generated Docker images using the
`org.opencontainers.image.revision` metadata label.

Fixes jenkinsci#865
Closes jenkinsci#892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
4 participants
@glefloch @oleg-nenashev @hjwk @timja