Do not require docker socket access in test #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [authentication-tokens](https://github.com/jenkinsci/authentication-tokens-plugin) from 1.4 to 1.53.v1c90fd9191a_b_. - [Release notes](https://github.com/jenkinsci/authentication-tokens-plugin/releases) - [Changelog](https://github.com/jenkinsci/authentication-tokens-plugin/blob/master/CHANGELOG.md) - [Commits](https://github.com/jenkinsci/authentication-tokens-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:authentication-tokens dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.67 to 4.68. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.67...plugin-4.68) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…gin-4.68' and 'dependabot/maven/org.jenkins-ci.plugins-authentication-tokens-1.53.v1c90fd9191a_b_' into octopus
Most recent version
|
@jglick I'd love to have the following pull requests merged before this pull request, with this one being labeled as a The following pull request is no longer needed |
|
Unfortunately this repo is not configured to allow merging of the base branch in the absence of conflicts, and I lack admin permission to enable that, so the diff will look larger than it really is. |
I'm happy to rework or replace the pull request with a much smaller diff if that will help the merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require docker socket access in test
In order to include the docker-commons plugin in the plugin bill of materials, the tests need to pass on agents that do not have access to the docker socket. One of the tests in the plugin assumed access to the docker socket, but did not do anything relevant with that access.
Remove the requirement for docker socket access from the test.
Also includes several other pull requests in the same request, since I think they should be included in the next release of the docker-commons plugin
If it will increase the chances of this being merged, I'm happy to provide a pull request that only makes the minimum changes necessary. I wanted this larger set of changes so that the incremental build can be tested in the plugin BOM.
Testing done
Automated tests confirmed to run as expected on Linux without docker socket access and Linux with docker socket access.
Submitter checklist