Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 11 support #890

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

MarkEWaite
Copy link
Contributor

Remove Java 11 support

Jenkins weekly 2.463 dropped support for Java 11. Jenkins LTS 2.479.1 will drop support for Java 11 when it releases 30 Oct 2024.

The Jenkins security team only provides security fixes for the most recent weekly release and the most recent LTS release. That means there will be no security updates for Jenkins LTS versions prior to 2.479.1 once it is released 30 Oct 2024.

Jenkins agents require a JDK that has the same major version as the controller or a greater JDK major version than the controller JVM. After 30 Oct 2024, there will be no supported configuration where Java 11 agents run. This change removes the Java 11 build and update process.

We can wait until 30 Oct 2024 to merge this change if needed, but there is not much reason to wait beyond 30 Oct 2024 for that merge.

Accept case insensitive location in HTTP response.

No longer generates container images for:

  • Alpine Linux JDK 11
  • Arch Linux
  • Debian JDK 11
  • Windows Nanoserver JDK 11
  • Windows Server Core JDK 11

Testing done

Confirmed that automated build and test passes on my Linux computer.

Confirmed that no Java 11 container image is created after this change.

Recreated the output in the README based on latest changes.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Jenkins weekly 2.463 dropped support for Java 11. Jenkins LTS 2.479.1
will drop support for Java 11 when it releases 30 Oct 2024.

The Jenkins security team only provides security fixes for the most
recent weekly release and the most recent LTS release. That means there
will be no security updates for Jenkins LTS versions prior to 2.479.1
once it is released 30 Oct 2024.

Jenkins agents require a JDK that has the same major version as the
controller or a greater JDK major version than the controller JVM. After
30 Oct 2024, there will be no supported configuration where Java 11
agents run. This change removes the Java 11 build and update process.

We can wait until 30 Oct 2024 to merge this change if needed, but there
is not much reason to wait beyond 30 Oct 2024 for that merge.

Accept case insensitive location in HTTP response.

No longer generates container images for:

* Alpine Linux JDK 11
* Arch Linux
* Debian JDK 11
* Windows Nanoserver JDK 11
* Windows Server Core JDK 11

Testing:

Confirmed that automated build and test passes on my Linux computer.

Confirmed that no Java 11 container image is created after this change.

Recreated the output in the README based on latest changes.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 6, 2024 19:24
@MarkEWaite MarkEWaite added the breaking Breaking change label Oct 6, 2024
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark!
Unfortunately, my review does not count. 😉

timja
timja previously approved these changes Oct 6, 2024
@MarkEWaite MarkEWaite dismissed timja’s stale review October 7, 2024 11:47

The merge-base changed after approval.

@MarkEWaite
Copy link
Contributor Author

Question has been raised to the platform SIG for further discussion on the timing of this change. I think we should merge it next week, but am open to further discussion.

@timja
Copy link
Member

timja commented Oct 7, 2024

🤷 no strong opinion, now is fine for me but so is next week or the end of the month.

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@MarkEWaite
Copy link
Contributor Author

Plan as agreed in Platform SIG meeting is to merge this early next week

@MarkEWaite MarkEWaite merged commit b5b810e into jenkinsci:master Oct 12, 2024
10 checks passed
@MarkEWaite MarkEWaite deleted the remove-java-11-support branch October 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change jdk11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants