Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updatecli): Track UBI9 version #885

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Sep 26, 2024

After @lemeurherve's work on the updatecli manifest to keep UBI9 updated in the docker bake file and Dockerfile, it became clear something wasn't working as expected when trying to find the latest version of the UBI9 container with the default updatecli behavior.

I then took Hervé's manifest and transitioned it into using a shell script to find the "right" version.
I discovered a Swagger description that led me to the correct API endpoint.
This endpoint allowed me to query the ubi9 containers, sorted by the last update date and filtered by the latest tag.
As a result, I obtained the version 9.4-1214.1726694543.

The script works as is but would need some additional refinement to return a list of versions rather than just the most recent one.

This could help partially solve #883.

Testing Done

I updated my local configuration to target my fork instead of upstream.
To test the changes, I intentionally kept my master branch out-of-date, and updatecli successfully created this PR for me.

The command used for testing:
updatecli diff --debug --config ./updatecli/updatecli.d/rhel-ubi9.yaml --values ./updatecli/values.github-action.yaml 2>&1

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar marked this pull request as ready for review September 26, 2024 12:49
@gounthar gounthar requested a review from a team as a code owner September 26, 2024 12:49
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a bit over complicated, does renovate or dependabot do this correctly and simpler?

@gounthar
Copy link
Contributor Author

I think dependabot handles the version retrieval pretty well, but I'm not sure it can update the docker bake file.

@timja
Copy link
Member

timja commented Sep 26, 2024

I think dependabot handles the version retrieval pretty well, but I'm not sure it can update the docker bake file.

renovate would be able to with the regex method pretty easily then in the bake file

@dduportal
Copy link
Contributor

Please note that this "issue" should be temporarily and updatecli should be fixed

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should merge this because it will keep us UBI-9 current.

@MarkEWaite MarkEWaite merged commit a733ec0 into jenkinsci:master Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants