Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix margin-bottom of jenkins-form-item #385

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jan 5, 2025

On the select pages and the dialogs the samples had no bottom margin when there was more than one item.

Before:
image
image

After:
image
image

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

On the select pages and the dialogs the samples had no bottom margin
when there was more than one item.
@mawinter69 mawinter69 requested a review from a team as a code owner January 5, 2025 22:33
Co-authored-by: Kris Stern <krisstern@outlook.com>
@timja timja added the developer label Jan 6, 2025
@timja timja merged commit 28150ef into jenkinsci:master Jan 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants