Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous content fixes + add a test for content #379

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Miscellaneous content fixes + add a test for content #379

merged 5 commits into from
Jan 2, 2025

Conversation

janfaracik
Copy link
Contributor

  • Miscellaneous content fixes
  • Fix a border issue on the spacing page
  • Add a test to ensure descriptions/dos-donts end with a full stop or a colon (this test setup could be merged with the other test, didn't feel it was too urgent considering how few tests this plugin has/needs)

@janfaracik janfaracik requested a review from a team as a code owner January 2, 2025 16:19
krisstern
krisstern approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janfaracik janfaracik merged commit 9bfb090 into jenkinsci:master Jan 2, 2025
17 checks passed
@janfaracik janfaracik deleted the content-test branch January 2, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@krisstern krisstern krisstern approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janfaracik @timja @krisstern