Add docs relating to the new 'App bar' subtitle feature #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhafner
reviewed
May 7, 2024
| <p class="jdl-leading-paragraph">${%topAppBar.description}</p> | ||
| <div class="jdl-component-group"> | ||
| <div class="jdl-component-sample jdl-component-sample--full-width jdl-component-sample--no-bottom-padding jdl-component-sample--gridless"> | ||
| <l:app-bar title="${%title}" subtitle="3"> |
There was a problem hiding this comment.
So is subtitle always a number? Shouldn't it then be called number or count or something more intuitive? Or is is planned to have there an subtitle text as well? Then it would make sense to have an example for such a page as well.
There was a problem hiding this comment.
I'm not too sure to be honest - trying not to be overly specific in case there is a future scenario where we might want to include text, only scenario I could currently think of is if we need to provide more context, e.g. https://jenkins-redesign.vercel.app/project/build/375/test-results
timja
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some small docs relating to jenkinsci/jenkins#9221 - happy to add more/tweak if this isn't clear. Also gave the app bar page a minor refresh, bringing it more inline with other pages.
Testing done
Submitter checklist