Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table rendering #297

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix table rendering #297

merged 1 commit into from
Dec 2, 2023

Conversation

mawinter69
Copy link
Contributor

fixes #294

When intergrating prism-api, the ability to to render the jelly as html was lost. This PR introduces an explicit flag to render and not apply prism

Testing done

Submitter checklist

Preview Give feedback

fixes jenkinsci#294

When intergrating prism-api, the ability to to render the jelly as html
was lost. This PR introduces an explicit flag to render and not apply
prism
@mawinter69 mawinter69 requested a review from a team as a code owner December 2, 2023 09:32
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but what's up with the formatting change in src/main/resources/io/jenkins/plugins/designlibrary/sample.js ?

@mawinter69
Copy link
Contributor Author

look at it with whitespace changes disabled. Then you see the change is actually just a few lines

@NotMyFault NotMyFault merged commit 26e2c5b into jenkinsci:master Dec 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table page rendering is broken
2 participants