Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument jdbc datasources with OpenTelemetry #259

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Sep 20, 2024

Instrument jdbc datasources with OpenTelemetry

Testing done

End to end tests:

  • Database Plugin + Junit SQL Storage Plugin doesn't enable the OpenTelemetry JDBC instrumentation
  • Database Plugin + Junit SQL Storage Plugin + configured OTel Plugin doesn't enable the OpenTelemetry JDBC instrumentation
  • Database Plugin + Junit SQL Storage Plugin + configured OTel Plugin with otel.instrumentation.jdbc.enabled=true enables OTel JDBC instrumentation on the Jenkins Controller but not on the build agents
  • Database Plugin + Junit SQL Storage Plugin + configured OTel Plugin with otel.instrumentation.jdbc.enabled=true & otel.instrumentation.jenkins.agent.enabled=true enables OTel JDBC instrumentation both on the Jenkins Controller nd on the build agents.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner September 20, 2024 12:41
@cyrille-leclerc
Copy link
Contributor Author

@timja please review

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM untested, could you fill in the testing done section of the template please? to cover off what types of testing you've done? e.g. controller, agent etc.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@cyrille-leclerc
Copy link
Contributor Author

Thanks @timja , details on all the tests added in the PR description (end to end tests)

@timja timja merged commit 1d03c76 into jenkinsci:master Sep 20, 2024
16 checks passed
@timja
Copy link
Member

timja commented Sep 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants