Use upstream Spotless configuration #290
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return Messages.Dashboard_IframePortlet(); | ||
| } | ||
|
|
||
| public FormValidation doCheckIframeSource(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| return FormValidation.error(error); | ||
| } | ||
| return FormValidation.ok(); | ||
| public FormValidation doCheckImageUrl(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| * | ||
| * @return the jobExecutionMode items | ||
| */ | ||
| public ListBoxModel doFillDisplayStatusItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| return Messages.Dashboard_IframePortlet(); | ||
| } | ||
|
|
||
| public FormValidation doCheckIframeSource(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
| return FormValidation.error(error); | ||
| } | ||
| return FormValidation.ok(); | ||
| public FormValidation doCheckImageUrl(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
| * | ||
| * @return the jobExecutionMode items | ||
| */ | ||
| public ListBoxModel doFillDisplayStatusItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
|
Thanks, @basil, much appreciated! 👍 |
You're welcome! I wanted to take this opportunity to remind you that as a long-time contributor, you are eligible to vote in the upcoming Jenkins Board and Officer Elections at https://community.jenkins.io/g/election-voter-2023 |
As of jenkinsci/plugin-pom#733 the upstream plugin parent POM provides a standard Spotless configuration that Jenkins plugins can opt into by adding a
.mvn_exec_spotlessfile. This PR removes the custom Spotless configuration in this repository in favor of the upstream one and reformats the entire repository accordingly. The benefit of this PR is increased consistency and standardization with the rest of the Jenkins ecosystem. If this PR is accepted, the next step would be to check in a.git-blame-ignore-revsfile so that this commit doesn't clutter up the Git blame view.