Use jenkins.baseline to reduce bom update mistakes
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Jan 14, 2025
pom.xml
Outdated
| @@ -37,6 +37,9 @@ | |||
| <properties> | |||
| <gitHubRepo>jenkinsci/dark-theme-plugin</gitHubRepo> | |||
| <changelist>9999999-SNAPSHOT</changelist> | |||
| <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ --> | |||
| <jenkins.baseline>2.426</jenkins.baseline> | |||
| <!-- TODO: should depend on baseline --> | |||
| <jenkins.version>2.453</jenkins.version> | |||
There was a problem hiding this comment.
could you update this to corresponding LTS line instead please?
There was a problem hiding this comment.
#484 set the jenkins version to 2.453 so I assume there was a reason for that?
I could bump the baseline and jenkins version to to 2.462.x instead. WDYT?
timja
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
jenkins.baselineinpom.xmlThis change is proposed by the plugin archetype and makes maintenance of
jenkins.versionandboma little easier.Testing done
None. Rely on
ci.jenkins.ioto test it.Submitter checklist