Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73175] Improve handling of duplicate nodes #173

Merged
merged 4 commits into from
Jun 7, 2024
Merged

[JENKINS-73175] Improve handling of duplicate nodes #173

merged 4 commits into from
Jun 7, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jun 7, 2024 •
edited
Loading

File nodes are now correctly mapped using the name and path. Additionally, method and class nodes now get a unique ID even when the report does not create one. For this option, the ignoreErrors property needs to be activated.

Based on the fix jenkinsci/coverage-model#113.

dependabot bot and others added 3 commits June 6, 2024 08:20
@dependabot
Bump org.jvnet.hudson.plugins:analysis-pom from 8.4.0 to 8.5.0
daf648b 
Bumps [org.jvnet.hudson.plugins:analysis-pom](https://github.com/jenkinsci/analysis-pom-plugin) from 8.4.0 to 8.5.0.
- [Release notes](https://github.com/jenkinsci/analysis-pom-plugin/releases)
- [Changelog](https://github.com/jenkinsci/analysis-pom-plugin/blob/main/CHANGELOG.md)
- [Commits](jenkinsci/analysis-pom-plugin@v8.4.0...v8.5.0)

---
updated-dependencies:
- dependency-name: org.jvnet.hudson.plugins:analysis-pom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@uhafner
Merge remote-tracking branch 'origin/dependabot/maven/org.jvnet.hudso…
689ebf9 
…n.plugins-analysis-pom-8.5.0' into filename-id
@uhafner
[JENKINS-73175] Improve handling of duplicate nodes.
d25c924 
File nodes are now correctly mapped using the name and path.
Additionally, method and class nodes now get a unique ID even when
the report does not create one. For this option, the `ignoreErrors`
property needs to be activated.
@uhafner uhafner added the enhancement Enhancement of existing functionality label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Looks good. No mutations were possible for these changes.
See https://pitest.org/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 270 passed)
   〰️   Line Coverage: 82% (495 missed lines)
   ➰   Branch Coverage: 76% (191 missed branches)
   PIT   Mutation Coverage: 47% (840 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: 17 warnings (0 error, 4 high, 13 normal, 0 low)
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Looks good. No mutations were possible for these changes.
See https://pitest.org/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 270 passed)
   〰️   Line Coverage: 82% (495 missed lines)
   ➰   Branch Coverage: 76% (191 missed branches)
   PIT   Mutation Coverage: 47% (840 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 779ff98 into main Jun 7, 2024
29 checks passed
@uhafner uhafner deleted the filename-id branch June 7, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uhafner