Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Prism API plugin for displaying the exported configuration YAML #2342

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

timja
Copy link
Member

@timja timja commented Aug 20, 2023

See jenkinsci/prism-api-plugin#107

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@timja timja force-pushed the integrate-prism branch 2 times, most recently from f785a2d to 71540a4 Compare August 20, 2023 16:19
plugin/pom.xml Outdated Show resolved Hide resolved
@timja timja marked this pull request as ready for review September 26, 2023 07:35
@timja timja requested a review from a team as a code owner September 26, 2023 07:35
@timja timja enabled auto-merge (squash) September 26, 2023 07:43
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy 👏

@timja timja merged commit 09593e8 into jenkinsci:master Sep 26, 2023
@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Sep 29, 2023

Could you edit the release notes to clarify that this does not change anything about how Prism API can be configured via CasC? And instead just makes the CasC plugin use the Prism API plugin for its own purposes rather than include a separate copy of the Prism JavaScript code.

For example: "Use the Prism API plugin for displaying the exported configuration YAML"

@timja timja deleted the integrate-prism branch September 29, 2023 10:43
@timja timja changed the title Integrate with Prism API plugin Use the Prism API plugin for displaying the exported configuration YAML Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants