Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove inline js from checkUrl #338

Merged
merged 1 commit into from
Sep 9, 2024
Merged

remove inline js from checkUrl #338

merged 1 commit into from
Sep 9, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Aug 26, 2024 •
edited
Loading

use checkDependsOn to deliver the value

Testing done

Manual testing validated the ID check is still working

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mawinter69
remove inline js from checkUrl
09fdd9e 
use checkDependsOn to deliver the value
@mawinter69 mawinter69 requested a review from a team as a code owner August 26, 2024 20:01
@alecharp alecharp added this pull request to the merge queue Sep 9, 2024
Merged via the queue into jenkinsci:master with commit 8e85886 Sep 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecharp alecharp alecharp approved these changes

Assignees
No one assigned
Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mawinter69 @alecharp