This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Remove agent-to-controller calls #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
============================================
- Coverage 58.17% 58.00% -0.18%
Complexity 483 483
============================================
Files 56 56
Lines 2305 2298 -7
Branches 290 289 -1
============================================
- Hits 1341 1333 -8
- Misses 858 859 +1
Partials 106 106
Continue to review full report at Codecov.
|
timja
approved these changes
Nov 4, 2021
uhafner
approved these changes
Nov 4, 2021
| throw new SecurityException("refusing to " + name + " on " + path); | ||
| } | ||
|
|
||
| @Extension public static class ChannelConfiguratorImpl extends ChannelConfigurator { |
There was a problem hiding this comment.
Shouldn't this be a TestExtension?
There was a problem hiding this comment.
No, because that would only apply within a single test. This deliberately gets loaded in all tests in the plugin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with jenkinsci/jenkins#5885. See https://github.com/jenkinsci/remoting-security-workaround-plugin/blob/main/README.adoc#affected-functionality.