Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TriggeredItem from ComputedFolder #264

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 19, 2022

Downstream of jenkinsci/jenkins#7131. Cleans up tech debt introduced in #20 (amended slightly in #119).

@jglick jglick marked this pull request as ready for review October 4, 2022 13:39
@jglick jglick requested a review from a team as a code owner October 4, 2022 13:39
Copy link
Contributor

@julieheard julieheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@olamy olamy merged commit 6df9a0e into jenkinsci:master Oct 7, 2022
@jglick jglick deleted the TriggeredItem branch October 7, 2022 11:51
@basil
Copy link
Member

basil commented Oct 10, 2022

Incompatible; needs a consumer to be adapted as described in jenkinsci/jenkins#7244 (review).

@riywo
Copy link

riywo commented Oct 11, 2022

FYI: This change starts causing our integration test failure as the current LTS version of Jenkins is 2.361.2 https://www.jenkins.io/download/

https://github.com/jenkinsci/autify-plugin/actions/runs/3212345732/jobs/5251131458#step:4:1522

We're going to switch to the latest Jenkins for our integration test, so it's ok for us. But the user who uses the Jenkins LTS version might face the same issue on their production.

@jglick
Copy link
Member Author

jglick commented Oct 11, 2022

the user who uses the Jenkins LTS version might face the same issue

No, because they would not be offered this update to begin with. The problem lies in your integration test script.

@riywo
Copy link

riywo commented Oct 11, 2022

Got it, thank you for your confirmation.

Just FYI: We use this tool to install the required plugins https://github.com/jenkinsci/plugin-installation-manager-tool

https://github.com/jenkinsci/autify-plugin/blob/main/integration-test/integration-test.bash#L55

@jglick
Copy link
Member Author

jglick commented Oct 11, 2022

--jenkins-version: (optional) Version of Jenkins to be used. If not specified, the plugin manager will try to extract it from the WAR file or other sources. The argument can be also set using the JENKINS_VERSION environment variable.

Without specifying the Jenkins version, or allowing it to be inferred, PIMT will just download the latest version of every plugin, whether it is compatible or not.

@riywo
Copy link

riywo commented Oct 11, 2022

I thought it would take the version from the WAR file specified by --war. Probably we should set the correct path for the WAR file because cwd is different. Thank you for pointing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants