-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TriggeredItem
from ComputedFolder
#264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Incompatible; needs a consumer to be adapted as described in jenkinsci/jenkins#7244 (review). |
FYI: This change starts causing our integration test failure as the current LTS version of Jenkins is 2.361.2 https://www.jenkins.io/download/ https://github.com/jenkinsci/autify-plugin/actions/runs/3212345732/jobs/5251131458#step:4:1522 We're going to switch to the latest Jenkins for our integration test, so it's ok for us. But the user who uses the Jenkins LTS version might face the same issue on their production. |
No, because they would not be offered this update to begin with. The problem lies in your integration test script. |
Got it, thank you for your confirmation. Just FYI: We use this tool to install the required plugins https://github.com/jenkinsci/plugin-installation-manager-tool https://github.com/jenkinsci/autify-plugin/blob/main/integration-test/integration-test.bash#L55 |
Without specifying the Jenkins version, or allowing it to be inferred, PIMT will just download the latest version of every plugin, whether it is compatible or not. |
I thought it would take the version from the WAR file specified by |
Downstream of jenkinsci/jenkins#7131. Cleans up tech debt introduced in #20 (amended slightly in #119).