Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use diamond operator, remove superflous throws and fixed some deprecation warnings #151

Merged
merged 1 commit into from
Jul 16, 2020
Merged

use diamond operator, remove superflous throws and fixed some deprecation warnings #151

merged 1 commit into from
Jul 16, 2020

Conversation

StefanSpieker
Copy link
Contributor

@StefanSpieker StefanSpieker commented Jul 12, 2020 •
edited
Loading

  • used diamond operator,
  • some try with resources
  • remove superflous throws and
  • fixed some deprecation warnings (most of junit deprecation of assertThrows)

Proposed changelog entries

  • Internal: Refactorings

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests

@fcojfernandez

@fcojfernandez
Copy link
Member

CI failed because of an infra issue. Closing and re-opening to re-launch the CI

@fcojfernandez fcojfernandez reopened this Jul 16, 2020
@fcojfernandez fcojfernandez merged commit 69eb6ed into jenkinsci:master Jul 16, 2020
@StefanSpieker StefanSpieker deleted the fix_deprecates branch July 16, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanSpieker @fcojfernandez