-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding french translation for message bundle #145
Conversation
Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
thanks for this PR @jbleduigou ! This week I don't have availability to review it, but I will have a look next one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor concern about job
usage in french.
Contrairement \u00e0 une vue qui n''est qu''un filtre, un dossier cr\u00e9e un espace de nommage distinct, de sorte que vous \ | ||
pouvez avoir plusieurs \u00e9l\u00e9ments du m\u00eame nom tant qu''ils se trouvent dans des dossiers diff\u00e9rents. | ||
|
||
RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un job d''un dossier (ou de la racine Jenkins) \u00e0 un autre. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe job
-> projet
.
RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un job d''un dossier (ou de la racine Jenkins) \u00e0 un autre. | |
RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un projet d''un dossier (ou de la racine Jenkins) \u00e0 un autre. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
I have updated my changes accordingly.
Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
thanks @alecharp ! Merging since the error in the CI is not related to this PR: a problem with the memo in the EC2 linux agent happened when the deploy of the incremental stage was executed |
Signed-off-by: Jean-Baptiste Le Duigou jb.leduigou@gmail.com
See JENKINS-61489.
@fcojfernandez