Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding french translation for message bundle #145

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

jbleduigou
Copy link
Contributor

Signed-off-by: Jean-Baptiste Le Duigou jb.leduigou@gmail.com

See JENKINS-61489.

@fcojfernandez

Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
@fcojfernandez
Copy link
Member

thanks for this PR @jbleduigou !

This week I don't have availability to review it, but I will have a look next one

@fcojfernandez
Copy link
Member

@alecharp @batmat could you help me with this review? thanks in advance, mates!

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor concern about job usage in french.

Contrairement \u00e0 une vue qui n''est qu''un filtre, un dossier cr\u00e9e un espace de nommage distinct, de sorte que vous \
pouvez avoir plusieurs \u00e9l\u00e9ments du m\u00eame nom tant qu''ils se trouvent dans des dossiers diff\u00e9rents.

RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un job d''un dossier (ou de la racine Jenkins) \u00e0 un autre.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe job -> projet.

Suggested change
RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un job d''un dossier (ou de la racine Jenkins) \u00e0 un autre.
RelocateAction.permission.desc=N\u00e9cessaire pour d\u00e9placer un projet d''un dossier (ou de la racine Jenkins) \u00e0 un autre.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!
I have updated my changes accordingly.

Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
@jbleduigou jbleduigou requested a review from alecharp March 29, 2020 13:38
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fcojfernandez
Copy link
Member

thanks @alecharp !

Merging since the error in the CI is not related to this PR: a problem with the memo in the EC2 linux agent happened when the deploy of the incremental stage was executed

@fcojfernandez fcojfernandez merged commit 9c85b74 into jenkinsci:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants