-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-58282] Ability to configure default folder health metrics #129
[JENKINS-58282] Ability to configure default folder health metrics #129
Conversation
@Dohbedoh the CI is failing. Did you have the chance to investigate the cause? |
I see heaps of |
cae19c2
to
25872b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I'll try to test it and in case it's ok, I will merge it
@fcojfernandez Maybe put this in WIP, I just want to add a test to make sure this is JCasC compatible. |
@Dohbedoh great! Some of us are working on adding JCasC compatibility. Here you have some examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's commit the update to configuration-as-code-1.30 and see if the CI passes
src/test/java/com/cloudbees/hudson/plugins/folder/ConfigurationAsCodeTest.java
Outdated
Show resolved
Hide resolved
@Dohbedoh I cannot commit my suggestions, please go ahead and I will merge the PR |
Co-Authored-By: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>
@fcojfernandez done. Thanks! |
@Dohbedoh please have a look at the issue JENKINS-60393. It was introduced by this change. |
See JENKINS-58282. Large instances are awfully impacted by performances issues related to health metrics. As a workaround, the health metrics can be removed but every time a new folder is created, it has all folder health metrics configured and there is no way around this. This feature is meant to help administrator to control this.
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)@fcojfernandez