Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58282] Ability to configure default folder health metrics #129

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Jul 29, 2019

See JENKINS-58282. Large instances are awfully impacted by performances issues related to health metrics. As a workaround, the health metrics can be removed but every time a new folder is created, it has all folder health metrics configured and there is no way around this. This feature is meant to help administrator to control this.

Proposed changelog entries

  • Ability to configure default folder health metrics

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests

@fcojfernandez

@fcojfernandez
Copy link
Member

@Dohbedoh the CI is failing. Did you have the chance to investigate the cause?

@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Jul 30, 2019

I see heaps of java.lang.NoClassDefFoundError: Could not initialize class org.jvnet.hudson.test.TestPluginManager and a java.nio.file.FileSystemException: /tmp/jenkins5656330164204821983: No space left on device. Trying to kick off the build again.

@Dohbedoh Dohbedoh closed this Jul 30, 2019
@Dohbedoh Dohbedoh reopened this Jul 30, 2019
@Dohbedoh Dohbedoh force-pushed the feature/JENKINS-58282 branch from cae19c2 to 25872b1 Compare July 30, 2019 02:33
Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'll try to test it and in case it's ok, I will merge it

@Dohbedoh
Copy link
Contributor Author

@fcojfernandez Maybe put this in WIP, I just want to add a test to make sure this is JCasC compatible.

@fcojfernandez
Copy link
Member

@Dohbedoh great! Some of us are working on adding JCasC compatibility. Here you have some examples:

Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's commit the update to configuration-as-code-1.30 and see if the CI passes

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@fcojfernandez
Copy link
Member

@Dohbedoh I cannot commit my suggestions, please go ahead and I will merge the PR

Co-Authored-By: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>
@Dohbedoh
Copy link
Contributor Author

@fcojfernandez done. Thanks!

@fcojfernandez fcojfernandez merged commit 8ac7f90 into jenkinsci:master Sep 18, 2019
@Dohbedoh Dohbedoh deleted the feature/JENKINS-58282 branch September 18, 2019 13:44
@darxriggs
Copy link
Contributor

@Dohbedoh please have a look at the issue JENKINS-60393. It was introduced by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants