Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to remove trigger #126

Merged
merged 5 commits into from
Mar 22, 2019
Merged

Add function to remove trigger #126

merged 5 commits into from
Mar 22, 2019

Conversation

LinuxSuRen
Copy link
Member

ComputedFolder doesn't provide a function to remove a trigger.

  • Entry 1: Feature, Provide a function to remove an exists trigger
  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests

@fcojfernandez

@fcojfernandez
Copy link
Member

Thanks @LinuxSuRen ! I'll try to review it next week

@fcojfernandez fcojfernandez self-requested a review January 17, 2019 09:26
@LinuxSuRen
Copy link
Member Author

ping @fcojfernandez

@fcojfernandez
Copy link
Member

Sorry @LinuxSuRen I've been really busy working on Jenkinsfile Runner and I couldn't make time. It's in my TODO list to review once I finish that tasks

@LinuxSuRen
Copy link
Member Author

ping @jenkinsci/code-reviewers

fcojfernandez and others added 3 commits March 22, 2019 09:51
@fcojfernandez @LinuxSuRen
Update src/test/java/com/cloudbees/hudson/plugins/folder/computed/Com…
248be1a 
…putedFolderTest.java

Co-Authored-By: LinuxSuRen <LinuxSuRen@gmail.com>
@daniel-beck @LinuxSuRen
Update src/main/java/com/cloudbees/hudson/plugins/folder/computed/Com…
97d53e1 
…putedFolder.java

Co-Authored-By: LinuxSuRen <LinuxSuRen@gmail.com>
@daniel-beck @LinuxSuRen
Update src/main/java/com/cloudbees/hudson/plugins/folder/computed/Com…
f774c34 
…putedFolder.java

Co-Authored-By: LinuxSuRen <LinuxSuRen@gmail.com>
@fcojfernandez fcojfernandez merged commit e9a4d5b into jenkinsci:master Mar 22, 2019
@LinuxSuRen LinuxSuRen deleted the fea/remove-trigger branch March 22, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck left review comments

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LinuxSuRen @fcojfernandez @daniel-beck @oleg-nenashev