Code cleanup #124
Code cleanup #124
Conversation
|
Hi @fcojfernandez and @oleg-nenashev, as some time already passed since this pull-request was created, I just wanted to check if it can be merged? |
|
I am not sure who maintains this plugin nowadays |
|
Will check |
There was a problem hiding this comment.
Code looks good to me, but after checking the summary of deprecated methods I see that the following methods are still in use:
- "hudson/model/View#getOwnerItemGroup()Lhudson/model/ItemGroup;"
- "hudson/model/View#onJobRenamed(Lhudson/model/Item;Ljava/lang/String;Ljava/lang/String;)V"
Is there any reason to keep those deprecated method?
|
I added another commit to replace |
|
About There are already Usages: |
According to the Javadoc, since Java 6 TimeUnit contains all required units.
The newer methods Jenkins#get and Jenkings#getInstanceOrNull make it more clear by name and annotation if null may be returned or not.
According to the Javadoc, ACL#as should be used in combination with a try-with-resources statement.
According to the Javadoc, SubTask#getOwnerTask should be called directly.
According to the Javadoc, it should not be used anymore due to risk for file leak.
According to the Javadoc, ViewGroup#getItemGroup should be called directly on the owner.
darxriggs
force-pushed
the
code-cleanup
branch
from
0c2c8b4 to
629f149
Compare
|
Hi @fcojfernandez, I now rebased on master and resolved the merge conflict. |
|
@darxriggs I think I will be able to work on this next week. Thanks a lot! |
The deprecated classes/methods have been found by https://ci.jenkins.io/job/Infra/job/deprecated-usage-in-plugins/job/master/lastSuccessfulBuild/artifact/output/usage-by-plugin.html.
I suggest to review the changes commit by commit.