Skip to content

Commit

Permalink
Merge pull request #260 from NotMyFault/ionicons-api
Browse files Browse the repository at this point in the history
feat: Make use of ionicons-api
  • Loading branch information
jtnord authored Nov 10, 2022
2 parents 93a7c5d + 382fa16 commit 495e640
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 12 deletions.
7 changes: 6 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</licenses>

<scm>
<connection>scm:git:git://github.com/${gitHubRepo}.git</connection>
<connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
<developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>
<url>https://github.com/${gitHubRepo}</url>
<tag>${scmTag}</tag>
Expand Down Expand Up @@ -66,6 +66,11 @@
</dependencyManagement>

<dependencies>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>ionicons-api</artifactId>
<version>19.v744f3b_2b_b_e4e</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>credentials</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ public String getUrlName() {
*/
@NonNull
public String getIconFileName() {
return "symbol-move plugin-cloudbees-folder";
return "symbol-move-outline plugin-ionicons-api";
}

/**
* {@inheritDoc}
*/
@Override
public String getIconClassName() {
return "symbol-move plugin-cloudbees-folder";
return "symbol-move-outline plugin-ionicons-api";
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ THE SOFTWARE.
<div class="jenkins-app-bar__content">
<h2>
<div class="jenkins-hidden">
<l:icon src="symbol-settings" />
<l:icon src="symbol-settings-outline plugin-ionicons-api" />
</div>
<span>${%General}</span>
</h2>
Expand All @@ -78,7 +78,7 @@ THE SOFTWARE.

<j:choose>
<j:when test="${descriptor.isLookAndFeelConfigurable(it)}">
<f:section title="${%Appearance}" icon="symbol-appearance plugin-cloudbees-folder">
<f:section title="${%Appearance}" icon="symbol-color-palette-outline plugin-ionicons-api">
<j:set var="views" value="${it.views}"/>
<j:if test="${it.folderViews.primaryModifiable and views.size()>1}">
<f:entry title="${%Default View}" field="defaultView">
Expand Down Expand Up @@ -136,7 +136,7 @@ THE SOFTWARE.
</j:otherwise>
</j:choose>

<f:section title="${%Health metrics}" icon="symbol-health plugin-cloudbees-folder">
<f:section title="${%Health metrics}" icon="symbol-pulse-outline plugin-ionicons-api">
<f:advanced title="${%Health metrics}" align="left">
<f:block>
<f:hetero-list descriptors="${descriptor.getHealthMetricDescriptors()}"
Expand All @@ -148,7 +148,7 @@ THE SOFTWARE.
</f:section>

<!-- folder property configurations -->
<f:section title="${%Properties}" icon="symbol-properties plugin-cloudbees-folder">
<f:section title="${%Properties}" icon="symbol-build-outline plugin-ionicons-api">
<f:descriptorList descriptors="${descriptor.getPropertyDescriptors()}" instances="${it.properties}" forceRowSet="true" />
</f:section>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt" xmlns:this="this">
<j:set var="url" value="${h.getNearestAncestorUrl(request,it)}"/>
<l:task icon="symbol-details" href="${url}/" title="${%Status}" contextMenu="false" />
<l:task icon="symbol-reader-outline plugin-ionicons-api" href="${url}/" title="${%Status}" contextMenu="false" />
<j:choose>
<j:when test="${h.hasPermission(it,it.CONFIGURE)}">
<l:task icon="icon-gear icon-md" href="${url}/configure" title="${%Configure}" />
Expand Down
1 change: 0 additions & 1 deletion src/main/resources/images/symbols/appearance.svg

This file was deleted.

1 change: 0 additions & 1 deletion src/main/resources/images/symbols/health.svg

This file was deleted.

1 change: 0 additions & 1 deletion src/main/resources/images/symbols/move.svg

This file was deleted.

1 change: 0 additions & 1 deletion src/main/resources/images/symbols/properties.svg

This file was deleted.

0 comments on commit 495e640

Please sign in to comment.