-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin parent POM #163
Conversation
The GitHub Actions failures here are not my fault, as this plugin uses a version of Checkstyle that requires Java 11 but has GitHub Actions configured to run with Java 8. |
jenkinsci/analysis-pom-plugin#420 should be reverted. |
I think we should move to JDK11 when building the plugins. I converted all of my active plugins (that depend on analysis-pom) to use JDK 11 quite some time ago. |
Done in commit 84b9587 |
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
Coverage 85.38% 85.38%
Complexity 152 152
=========================================
Files 17 17
Lines 746 746
Branches 57 57
=========================================
Hits 637 637
Misses 89 89
Partials 20 20 Continue to review full report at Codecov.
|
Build is now green. |
Thank you! A release of this would facilitate Java 17 PCT testing. |
I have been attempting to run PCT tests in
jenkinsci/bom
against Java 17 and newer versions of PCT, and this plugin is running into failures because its parent POM is too old. This PR updates the parent POM to the latest build toolchain from jenkinsci/analysis-pom-plugin#446 to facilitate Java 17 compatibility testing and PCT updates injenkinsci/bom
.