[JENKINS-72958] expose primary field to REST API #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That feels like the more general way to do this, at the expense of a slightly more complicated URL. Would mean adding |
MarkRx
force-pushed
the
feature/JENKINS-72958
branch
from
bc79131 to
9b251ab
Compare
|
Updated to expose beans instead. jenkinsci/scm-api-plugin#259 for scm-api change This will function without the above change but it won't show PrimaryInstanceMetadataAction. This means it can be merged independent of the scm-api changes though it would also be an option to wait for the scm-api release then bump up the dependency version to ensure the exposing of PrimaryInstanceMetadataAction is pulled in. |
rsandell
approved these changes
Apr 23, 2024
rsandell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a "primary" field to the REST API indicating if the SCM declared the branch as a default/primary branch.
https://issues.jenkins.io/browse/JENKINS-72958
Requires jenkinsci/scm-api-plugin#259 to see PrimaryInstanceMetadataAction class.
Testing done
Create a multi-branch pipeline branch with "myprinarybranch" as the default branch
Primary Branch
http://localhost:8080/jenkins/job/test/job/myprimarybranch/api/xml?tree=property[branch[*]]
{ "_class": "org.jenkinsci.plugins.workflow.job.WorkflowJob", "property": [ { "_class": "org.jenkinsci.plugins.workflow.multibranch.BranchJobProperty", "branch": { "actions": [ { "_class": "jenkins.scm.api.metadata.PrimaryInstanceMetadataAction" } ], "head": { "_class": "jenkins.plugins.git.GitBranchSCMHead", "name": "myprimarybranch", "origin": { "_class": "jenkins.scm.api.SCMHeadOrigin$Default" } }, "properties": [], "scm": { "_class": "hudson.plugins.git.GitSCM", "browser": null, "type": "hudson.plugins.git.GitSCM", "branches": [ {} ], "mergeOptions": {}, "userRemoteConfigs": [ {} ] } } } ] }Non-Primary Branch
http://localhost:8080/jenkins/job/test/job/otherbranch/api/xml?tree=property[branch[*]]
{ "_class": "org.jenkinsci.plugins.workflow.job.WorkflowJob", "property": [ { "_class": "org.jenkinsci.plugins.workflow.multibranch.BranchJobProperty", "branch": { "actions": [], "head": { "_class": "jenkins.plugins.git.GitBranchSCMHead", "name": "otherbranch", "origin": { "_class": "jenkins.scm.api.SCMHeadOrigin$Default" } }, "properties": [], "scm": { "_class": "hudson.plugins.git.GitSCM", "browser": null, "type": "hudson.plugins.git.GitSCM", "branches": [ {} ], "mergeOptions": {}, "userRemoteConfigs": [ {} ] } } } ] }Submitter checklist