Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the standard Jenkins icons #425

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

NotMyFault
Copy link
Member

The change proposed adapts the standard Jenkins icons (ionicons) used in core itself. In this case, the icons look most the same, but ionicons support our theme-ability API and are recommended to use.

@NotMyFault NotMyFault requested a review from a team as a code owner January 4, 2024 09:14
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK in hpi:run.

@jglick jglick merged commit 1425d1c into jenkinsci:master Jan 5, 2024
14 checks passed
@NotMyFault NotMyFault deleted the adapt-standard-jenkins-icons branch January 5, 2024 14:31
@NotMyFault
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants