Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test git plugin pre-release build #4061

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 3, 2024

Test git plugin pre-release builds

Git plugin 5.6.1-rc5357.7a_4955e76288 adds credentials to the GitClient object before decorating the object with settings from extensions. A plugin that adds a deocrator will now be able to adjust the credentials if needed.

Jira issue for the change of ordering of GitClient decoration is:

Rejected changes

The pre-release git client plugin fails the warnings-ng tests with a null pointer exception. Those changes have been removed from this pull request in commit d4df168

Testing done

Checked that a few plugins that depend on the git plugin are passing their automated tests in the BOM context.

PLUGINS=github-branch-source,cloudbees-bitbucket-branch-source,,mailer TEST=InjectedTest bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Git client plugin 6.1.1-rc3643.ff37e600016d includes JGit 7.1.0.
JGit 7.1.0 is scheduled to release 4 Dec 2024, so there is a small chance
that the version will be updated before the official release.

Git client plugin pull request for JGit 7.1.0 is:

* jenkinsci/git-client-plugin#1220

JGit 7.1.0 release notes are:

* https://projects.eclipse.org/projects/technology.jgit/releases/7.1.0

Git plugin 5.6.1-rc5357.7a_4955e76288 adds credentials to the GitClient
object before decorating the object with settings from extensions.
A plugin that adds a deocrator will now be able to adjust the credentials
if needed.

* jenkinsci/git-plugin#1687
* https://issues.jenkins.io/browse/JENKINS-73677

Tested by running:

PLUGINS=github-branch-source,cloudbees-bitbucket-branch-source,,mailer TEST=InjectedTest bash local-test.sh
@MarkEWaite
Copy link
Contributor Author

Null pointer exception is reported from JGit 7.1.0 API change in DiffFormatter. See the test failure with the command:

LINE=weekly PLUGINS=warnings-ng TEST=GitForensicsITest bash local-test.sh

Closing the pull request. It has found an issue and achieved its goal.

@MarkEWaite MarkEWaite closed this Dec 4, 2024
Fails GitForensicsTest from warnings-ng plugin with NPE
@MarkEWaite
Copy link
Contributor Author

Reopening the pull request to test the git plugin pre-release without the git client plugin pre-release.

@MarkEWaite MarkEWaite reopened this Dec 4, 2024
@MarkEWaite MarkEWaite changed the title Test git client plugin and git plugin pre-release builds Test git plugin pre-release build Dec 4, 2024
@MarkEWaite
Copy link
Contributor Author

Tests passed with the git plugin pre-release. Closing the pull request.

@MarkEWaite MarkEWaite closed this Dec 4, 2024
@MarkEWaite MarkEWaite deleted the test-git-client-and-git-plugin-pre-releases branch December 4, 2024 14:27
MarkEWaite added a commit to MarkEWaite/docker-lfs that referenced this pull request Dec 4, 2024
Fails BOM tests in the warnings-ng plugin.  Stay with git client plugin
6.1.0 so that the warnings-ng plugin is not disrupted.

Failure in plugin BOM can be seen with this command:

LINE=weekly PLUGINS=warnings-ng TEST=GitForensicsITest bash local-test.sh

Comment in GitHub pull request that shows the failure:

jenkinsci/bom#4061 (comment)

This reverts commit 8c8ecad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant