Use tagNameFormat to include correct tag in released pom file #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 933.0.1 pom file stored in the Jenkins artifact repository includes an invalid scm.tag value because the tagNameFormat property was removed on the 933.x branch. https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#tagNameFormat Docs say the default tagNameFormat is '@{project.artifactId}-@{project.version}'. That matches with the value that is in the pom file, 'cloudbees-bitbucket-branch-source-933.0.1'. Download the release 933.0.1 pom file from https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/plugins/cloudbees-bitbucket-branch-source/933.0.1/cloudbees-bitbucket-branch-source-933.0.1.pom The 933.0.1 release cannot be included in the Jenkins plugin BOM because of that invalid scm.tag. A 933.0.2 release is needed after this change is merged so that the released pom file includes the tag value that matches the tag written to the repository by the Apache Maven release plugin.
|
release 933.0.2 on going |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use tagNameFormat to include correct tag in released pom file
The 933.0.1 pom file stored in the Jenkins artifact repository includes an invalid scm.tag value because the tagNameFormat property was removed on the 933.x branch.
Apache Maven release plugin documentation says the default tagNameFormat is '@{project.artifactId}-@{project.version}'. That matches with the value that is in the pom file, 'cloudbees-bitbucket-branch-source-933.0.1'. It does not match the value written to the git repository.
The 933.0.1 release cannot be included in the Jenkins plugin BOM because of that invalid scm.tag. A 933.0.2 release is needed after this change is merged so that the released pom file includes the tag value that matches the tag written to the repository by the Apache Maven release plugin.
Refer to the failing plugin BOM pull request:
Your checklist for this pull request