Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename createSummary display name to Create Summary #77

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Rename createSummary display name to Create Summary #77

merged 2 commits into from
Jun 1, 2023

Conversation

dparapanov
Copy link
Member

@dparapanov dparapanov commented Dec 7, 2022 •
edited
Loading

The previous display name of createSummary step was Print Message which is the same as the display name of the echo step from Basic Step Plugin which is confusing. The display name of echo step here

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Rename createSummary display name to Create Summary
54a894c 
The previous display name of createSummary step was Print Message which
is the same as the display name of the echo step from Basic Step Plugin
and its confusing
MarkEWaite
MarkEWaite approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@MarkEWaite MarkEWaite added the bug Something isn't working label Dec 7, 2022
@dparapanov dparapanov closed this Dec 7, 2022
@dparapanov dparapanov reopened this Dec 7, 2022
@MarkEWaite MarkEWaite enabled auto-merge (squash) June 1, 2023 14:40
@MarkEWaite MarkEWaite merged commit 7f24fb9 into jenkinsci:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dparapanov @MarkEWaite