Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Jenkins 2.346.3 as minimum Jenkins version #71

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Require Jenkins 2.346.3 as minimum Jenkins version #71

merged 1 commit into from
Nov 8, 2022

Conversation

MarkEWaite
Copy link
Contributor

Require Jenkins 2.346.3 or newer

https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ recommends either 2.332.4 or 2.346.3.

Also removes the java.level property because that is no longer required with the most recent parent pom.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Require Jenkins 2.346.3 as minimum Jenkins version
6158382 
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
recommends either 2.332.4 or 2.346.3.

Also removes the `java.level` property because that is no longer required
with the most recent parent pom.
@MarkEWaite MarkEWaite added the chore Reduce maintenance label Nov 7, 2022
@MarkEWaite MarkEWaite enabled auto-merge November 7, 2022 21:29
gounthar
gounthar approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. 👍

@MarkEWaite MarkEWaite merged commit 0b4b9ff into jenkinsci:master Nov 8, 2022
@MarkEWaite MarkEWaite deleted the require-newer-core branch November 8, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

Assignees
No one assigned
Labels
chore Reduce maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkEWaite @gounthar