Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UI tests #214

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Introduce UI tests #214

merged 4 commits into from
Nov 19, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Following on #210 (comment) this PR aims to introduce UI tests.

While implementing those tests I noticed that summaries without an icon are currently "omitted" without any notice. As the jelly tag summary that we use requires a value I added a fallback that will return the emtpy.png from jenkins core alongside logging a warning. This allows us to create "text-only" summaries.

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd added the test Improvements to test and test infrastructure label Nov 19, 2024
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner November 19, 2024 09:35
@strangelookingnerd strangelookingnerd enabled auto-merge (squash) November 19, 2024 09:41
@strangelookingnerd strangelookingnerd merged commit 59ed594 into master Nov 19, 2024
17 of 18 checks passed
@strangelookingnerd strangelookingnerd deleted the introduce_ui_tests branch November 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improvements to test and test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant