Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.479.1 or newer #202

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

strangelookingnerd
Copy link
Contributor

Upgrades the plugin to use the 2.479 baseline alongside the latest plugin-bom.

Testing done

Delegated to CI.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner October 31, 2024 10:10
@strangelookingnerd
Copy link
Contributor Author

No need to merge (yet). Just a preparation for when the times right.

@strangelookingnerd strangelookingnerd added the dependencies Pull requests that update a dependency file label Oct 31, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two commits that were suggested by the OpenRewrite Migrate to Java 17 step. If those are unacceptable, you are welcome to revert them or force push to remove them.

Changes look good to me.

@MarkEWaite MarkEWaite changed the title Use 2.479 baseline Require Jenkins 2.479.1 or newer Nov 1, 2024
@strangelookingnerd
Copy link
Contributor Author

@jenkinsci/badge-plugin-developers Any objections to merge and release this change?

@strangelookingnerd strangelookingnerd self-assigned this Nov 4, 2024
@strangelookingnerd strangelookingnerd merged commit a9e138a into master Nov 4, 2024
20 checks passed
@strangelookingnerd strangelookingnerd deleted the use_2.479_baseline branch November 4, 2024 15:14
@strangelookingnerd strangelookingnerd mentioned this pull request Nov 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants